-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return value and typing documentation discrepancies #137
Comments
The basic issue is that |
that might be a more extensible and modular approach, instead of having to incorporate a |
Adding the "generator" classes would change the API a little bit which also requires a change in tests. Is that OK to proceed with it? I can create a new branch and try it and then switch back to pyschism effort |
Actually I guess it might be better if instead of a single generator class, we have a generator for each forcing inside the model (e.g. |
If we use generators, we need to find a good way to take care of |
sure thing! I think that would work with only a few changes |
@zacharyburnettNOAA I'm still a little bit stuck here. The ideal solution for me looks like this: I can move the What do you think? For now instead of this refactoring, I'll focus on adding SCHISM. But let's continue discussing the approach to refactoring to make it ocean model agnostic! |
While working on adding
PySCHISM
support, I noticed that in bothPySCHISM
andADCIRCPy
some of the "model forcing" types are not actually derived from the baseForcing
(in case ofADCIRCPy
) orModelForcing
(in case ofPySCHISM
) types. One example of this isTides
type in both.In spite of this, the return values are assumed to be of
Forcing
type forADCIRCPy
configuration classes:CoupledModelDriver/coupledmodeldriver/configure/forcings/base.py
Lines 148 to 149 in a97e5ec
How should this be addressed? This issue becomes more crucial when adding other models (e.g. PySCHISM in my case #136).
This issue discusses possible solutions for this issue
The text was updated successfully, but these errors were encountered: