Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] eth_estimateGas returns too many arguments #414

Closed
mateipopp opened this issue Jun 20, 2024 · 3 comments
Closed

[RPC] eth_estimateGas returns too many arguments #414

mateipopp opened this issue Jun 20, 2024 · 3 comments

Comments

@mateipopp
Copy link

System information

Erigon version: erigon version 1.2.9-dev
OS & Version: Linux

Commit hash: cc88640

Erigon Command (with flags/config):
/usr/local/bin/rpcdaemon --datadir /node/data --http.api=eth,erigon,web3,net,debug,trace,txpool
--http.addr=0.0.0.0 --ws --http.vhosts=* --http.corsdomain=*
--rpc.gascap=1125899906842624 --private.api.addr="127.0.0.1:9191"
--rpc.batch.limit=10000 --rpc.returndata.limit=134216728

Chain/Network: bsc-mainnet

Expected behaviour:

on geth bsc node is working as expected:
curl -X POST
-H "Content-Type: application/json"
--data '{
"jsonrpc": "2.0",
"method": "eth_estimateGas",
"id": 886848,
"params": [{"data": "0x95d89b41","to": "0x2a03a891add2dc6d0f7b94419086630ba5cb65b6"},"latest"]
}'
localhost:8545
returns:
{"jsonrpc":"2.0","id":886848,"result":"0x52ed"}

Actual behaviour

curl -X POST
-H "Content-Type: application/json"
--data '{
"jsonrpc": "2.0",
"method": "eth_estimateGas",
"id": 886848,
"params": [{"data": "0x95d89b41","to": "0x2a03a891add2dc6d0f7b94419086630ba5cb65b6"},"latest"]
}'
localhost:8545
{"jsonrpc":"2.0","id":886848,"error":{"code":-32602,"message":"too many arguments, want at most 1"}}

@blxdyx
Copy link
Collaborator

blxdyx commented Jun 20, 2024

Seems not a bug. Erigon remove it in this pr. erigontech#10495
It will not accept blockNumberOrhash, just same as geth.

@blxdyx blxdyx closed this as completed Jun 24, 2024
@mateipopp
Copy link
Author

It seems like this PR has been reverted. You can see it here: PR 10904.

@blxdyx
Copy link
Collaborator

blxdyx commented Jun 28, 2024

Yes, update in latest main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants