Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNWindow plans #5

Open
jswhisperer opened this issue Sep 17, 2020 · 1 comment
Open

VNWindow plans #5

jswhisperer opened this issue Sep 17, 2020 · 1 comment

Comments

@jswhisperer
Copy link
Contributor

Sorry to bother again I wanted to clarify I was reading https://github.com/nodegui/vue-nodegui/blob/master/src/widgets/Window/VNWindow.ts is there plans / needed help to port all the functions of QMainWindow in the future.
It says right now "You would not be using this widget in your app." I'm making use of it with the react nodegui (for fun) to create systemtray icons, detect the close event, set the title etc.
Happy to try helping with porting the functionality but I'm a bit new to TypeScript.

@shubhamzanwar
Copy link
Member

shubhamzanwar commented Sep 18, 2020

Currently, the renderer automatically creates the window and renders the app inside that window.
To make it more like react-nodegui (allowing systemtray icons, etc) we would need to implement more props for the VNWindow widget. Once that's done, the user will be able to use <vn-window> as a component in their code.

If you're interested in trying to implement, you can take a look at the other widgets as an example (VNView or VNText) 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants