feat(git-node): use a single git push command
#870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably wiser to wait for a release proposal PR to be open so this can be tested, I reckon I might be missing a |
|
Right, so I'm going to land #868 without this change |
|
Just tested it with nodejs/node#55879, a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot see why we would prefer having several
git pushcommands. However, I see a number of reasons to have only one, at the very end of the--promotesequence:git pushfor whatever reason.--continue(cc @RafaelGSS); with this PR, you either have pushed and the only remaining command istools/release.sh, or you haven't pushed and can start over.