-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 22.5.0 started to crash and hangs on different cases #53902
Node 22.5.0 started to crash and hangs on different cases #53902
Comments
Given the stack trace you've produced, I've optimistically applied the |
#53627 seems like the likely culprit. |
Also, for reference, the erroring line is Line 994 in 7b573d1
|
Similar issue showing up in Yarn (yarnpkg/berry#6398), it either hangs or if run with |
I've opened a revert PR #53904 if this needs to be reverted. |
@joyeecheung Any idea how is this possible?
|
This needs a better repro than the following command which runs 10+ subprocesses.
|
https://github.com/latin-1/berry-node-22.5.0-broken/ is slightly better, but not perfect.
|
I can not test it locally, but technically this should fix the bug: #53910 |
I think we should hold on landing future fast API pull requests until we have a way to guarantee that the added code paths are tested. |
OK I found a reproduction, and the fix I proposed works. Here's the repro:
Agreed. |
@RedYetiDev Note that the issue happens in the |
#53910 doesn't fix #53902 (comment) but reverting #53627 does. |
This comment has been minimized.
This comment has been minimized.
|
#53910 fixes the issue. What makes you think that it doesn't fix the issue? |
@anonrig They might be two different issues with |
If that's the issue, can you open a different/new issue with a reproducible test case? |
Not the one I linked to in that comment.
Yeah, with that PR (or when I git revert #53627 on v22.5.0) the |
how can i upgrade to v22.5.1 on docker? it is returning me that error: ERROR: failed to solve: node:22.5.1: failed to resolve source metadata for docker.io/library/node:22.5.1: no match for platform in manifest: not found |
Yup same.. |
Node.js v22.5.1 is available on Docker since Jul 19, 2024 at 2:42 PM Pacific It takes some time, as it's done using a PR by automation bot post-release which needs to be manually reviewed and merged. |
The CI builds started failing on node `v22.5.0` likely due to nodejs/node#53902 The NodeJS version on CI was therefore pinned to 21 in #272 This pull request goes back to using the latest NodeJS version, and should be merged to master once the issue with NodeJS `v22.5.0` noted above is fixed, and the build on this pull request succeeds.
This PR reverts #64, since nodejs/node#53902 has been resolved in [Node.js 22.5.1](https://nodejs.org/en/blog/release/v22.5.1).
…a patch.…" This reverts commit d2832db.
Reverts #16709 The underlying issue has been fixed in node 20.5.1 nodejs/node#53902 Fixes #16707
Version
22.5.0
Platform
What steps will reproduce the bug?
Now I haven't much time to properly debug it, so a couple of cases:
Clone
core-js
repo.npm i
just hangs on.Ok, if we somehow install dependencies and run
npm test
, Node crashes with:on this script.
The same error happens, for example, if we somehow built it (for example, with the previous Node version) and run other scripts like this.
In most of those cases used
zx
and / orkonan
.Sure, before Node 22.5.0, everything worked fine.
The text was updated successfully, but these errors were encountered: