Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove redundant global RegExps #56182

Merged
merged 1 commit into from
Dec 10, 2024
Merged

lib: remove redundant global RegExps #56182

merged 1 commit into from
Dec 10, 2024
+2 −2

Conversation

gurgunday
Copy link
Contributor

Small PR that replaces RegExps with .replaceAll when possible

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. util Issues and PRs related to the built-in util module. labels Dec 8, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (ac7fea6) to head (f9a7c96).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56182      +/-   ##
==========================================
+ Coverage   88.01%   88.48%   +0.47%     
==========================================
  Files         656      656              
  Lines      189136   189136              
  Branches    36004    36317     +313     
==========================================
+ Hits       166461   167366     +905     
+ Misses      15842    14975     -867     
+ Partials     6833     6795      -38
Files with missing lines Coverage Δ
lib/internal/util/debuglog.js 95.20% <100.00%> (+3.83%) ⬆️
lib/url.js 100.00% <100.00%> (+1.05%) ⬆️

... and 96 files with indirect coverage changes

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63939/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63943/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit eef06f7 into nodejs:main Dec 10, 2024
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eef06f7

aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@gurgunday @aduh95
lib: remove redundant global regexps
f10239f 
PR-URL: #56182
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@juanarbol juanarbol juanarbol approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gurgunday @nodejs-github-bot @lpinca @anonrig @targos @juanarbol @LiviaMedeiros