Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about release the 0.6.9 to make the following bug disappear #96

Open
xidui opened this issue Aug 14, 2015 · 7 comments
Open

How about release the 0.6.9 to make the following bug disappear #96

xidui opened this issue Aug 14, 2015 · 7 comments

Comments

@xidui
Copy link

xidui commented Aug 14, 2015

TypeError: triangle.css is not a function

I encountered such error, and after I read the source code, I found the error here:

if (triangle) {
              if (placement === 'top' || placement === 'bottom') {
                left = rect.left + rect.width / 2 - left;
                triangle.css('left', left.toString() + 'px');
              } else {
                top = rect.top + rect.height / 2 - top;
                triangle.css('top', top.toString()  + 'px');
              }
            }

triangle can be '[]', which may pass the check of 'if',

I also found that the problem is solved last month but not released. So how about make a release?

By the way
6.9 is my birthday, so I make this issue to ask for the '0.6.9' release ,hahaha~

@wescopeland
Copy link

+1

1 similar comment
@danfitz36
Copy link

+1

@wescopeland
Copy link

@xidui As a temporary solution, in your bower.json file you can reference the latest commit:

"nsPopover": "c444ad0764e2dabe93a1bde1977a2e2a408a7bde"

@xidui
Copy link
Author

xidui commented Aug 26, 2015

@wescopeland thank you for your suggestion

@MartyIX
Copy link

MartyIX commented Nov 7, 2015

+1

@lukefrake
Copy link

I've spent a good couple of hours looking into this bug.

There is a huge diff between this repo and what comes down from bower

@biamacedo
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants