Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong cursor position after exiting #16

Open
Josh-Cena opened this issue Sep 14, 2021 · 1 comment
Open

Wrong cursor position after exiting #16

Josh-Cena opened this issue Sep 14, 2021 · 1 comment

Comments

@Josh-Cena
Copy link

Josh-Cena commented Sep 14, 2021

Thanks for the terrific work :P Really had fun with it

One thing I'm noticed: every time I exit the process, the cursor is always at the very top of the console.

Test

I would have to hit enter multiple times to bring my cursor back to the original position to start typing again. I think this is related to how renderFrame works? Maybe we need to save the cursor position at the start and restore it with cursorTo before exit?

I'd be willing to fix this myself, just in a few days :D

Update. For some reason I can't reproduce in my console. I'm on MacOS and the above demo uses the VS Code terminal, but when I use the system's native terminal the cursor behaves correctly, so still investigating

@nojvek
Copy link
Owner

nojvek commented Nov 8, 2021

I most likely need to use alternate frame buffer for the rain effect. Revert back to main buffer on exit.

Will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants