Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color config #4

Open
DyckGerman opened this issue Dec 4, 2018 · 4 comments
Open

Background color config #4

DyckGerman opened this issue Dec 4, 2018 · 4 comments

Comments

@DyckGerman
Copy link

DyckGerman commented Dec 4, 2018

Really happy about the introduced font color option.

It looks like my zsh theme (or something else) makes the background gray, but i want black.
Could you please add background color option and use it to clear screen before frame rendering?

clearScreen: () => `${ctlEsc}2J`,

image

@nojvek
Copy link
Owner

nojvek commented Dec 4, 2018

Can you confirm you are on 2.0.3? I added this https://github.com/nojvek/matrix-rain/blob/master/index.js#L199 which should force a black background.

you can npm install -g matrix-rain again and it should pull the latest version.

@DyckGerman
Copy link
Author

I checked that again and it is reproducible with 2.0.3 on Debian 9 and Ubuntu 18

According to colors section from here, 40 as a black background should work, but for me only \x1b[30;1m worked as a real black.

Just don't mind, i believe it can be treated as an environment issue and closed

@nojvek
Copy link
Owner

nojvek commented Dec 6, 2018

30;1m is the foreground color, may be I'll do both and clear the screen.

@DyckGerman can you try re-installing with npm install -g matrix-rain to use 2.0.4, I'm doing a clear with both 30 and 40 (fg and bg).

@DyckGerman
Copy link
Author

@nojvek, tried 2.0.5 on Ubuntu again, see no improvements. I will share the code that works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants