⚡ Improve footer logo when no dark src

nonebot · Sep 26, 2023 · b880e92 · b880e92
1 parent 72e5413
commit b880e92
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 17 deletions.
diff --git a/packages/theme-nonepress/src/theme/Footer/Logo/index.tsx b/packages/theme-nonepress/src/theme/Footer/Logo/index.tsx
@@ -1,27 +1,42 @@
 import React from "react";
 
 import Link from "@docusaurus/Link";
-import { useBaseUrlUtils } from "@docusaurus/useBaseUrl";
+import useBaseUrl from "@docusaurus/useBaseUrl";
 
 import type { Props } from "@theme/Footer/Logo";
 import ThemedImage from "@theme/ThemedImage";
 
 function LogoImage({ logo }: Props) {
-  const { withBaseUrl } = useBaseUrlUtils();
-  const sources = {
-    light: withBaseUrl(logo.src),
-    dark: withBaseUrl(logo.srcDark ?? logo.src),
-  };
-  return (
-    <ThemedImage
-      className={logo.className}
-      alt={logo.alt}
-      sources={sources}
-      width={logo.width}
-      height={logo.height}
-      style={logo.style}
-    />
-  );
+  const lightSrc = useBaseUrl(logo.src);
+  const darkSrc = useBaseUrl(logo.srcDark ?? logo.src);
+
+  if (logo.srcDark == null) {
+    return (
+      <img
+        className={logo.className}
+        src={lightSrc}
+        alt={logo.alt}
+        width={logo.width}
+        height={logo.height}
+        style={logo.style}
+      />
+    );
+  } else {
+    const sources = {
+      light: lightSrc,
+      dark: darkSrc,
+    };
+    return (
+      <ThemedImage
+        className={logo.className}
+        alt={logo.alt}
+        sources={sources}
+        width={logo.width}
+        height={logo.height}
+        style={logo.style}
+      />
+    );
+  }
 }
 
 export default function FooterLogo({ logo }: Props): JSX.Element {

diff --git a/packages/theme-nonepress/src/theme/Logo/index.tsx b/packages/theme-nonepress/src/theme/Logo/index.tsx
@@ -19,7 +19,7 @@ function LogoThemedImage({
   imageClassName?: string;
 }): JSX.Element {
   const lightSrc = useBaseUrl(logo.src);
-  const darkSrc = useBaseUrl(logo.srcDark || logo.src);
+  const darkSrc = useBaseUrl(logo.srcDark ?? logo.src);
 
   // Is this extra div really necessary?
   // introduced in https://github.com/facebook/docusaurus/pull/5666