Merge pull request #7264 from shirady/lint-const-let

Change Rules In `.eslintrc.js` + Bump `eslint` Version
noobaa · Apr 16, 2023 · 50a6761 · 50a6761
2 parents fdebb3a + 7cfcad1
commit 50a6761
Show file tree

Hide file tree

Showing 215 changed files with 1,932 additions and 1,939 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -169,6 +169,11 @@ module.exports = {
         // instead of expression (foo = function() {})
         'func-style': ['error', 'declaration', { allowArrowFunctions: true }],
 
+        "prefer-const": ["error", {
+            "destructuring": "all",
+            "ignoreReadBeforeAssign": false
+        }],
+
         //////////////////////////////////////////////////////////////////////
         //                                                                  //
         // WARN                                                             //
@@ -295,9 +300,6 @@ module.exports = {
         // we do allow _name or name_ as identifiers
         'no-underscore-dangle': 'off',
 
-        // prefer to use let/const instead of var
-        'no-var': 'off',
-
         // turn off todo/fixme comments - will grep it to a different report
         'no-warning-comments': 'off',
 
@@ -319,9 +321,6 @@ module.exports = {
         // prefer using arrow functions for callbacks, but too much to fix
         'prefer-named-capture-group': 'off',
 
-        // we prefer using const, but too much to fix
-        'prefer-const': 'off',
-
         // we prefer using destructuring, but too much to fix
         'prefer-destructuring': 'off',
 
@@ -356,5 +355,8 @@ module.exports = {
 
         //Allow spacing between template tags and their literals
         'template-tag-spacing': 'off',
+
+        // we prefer not to adopt the logical assignment operators from ES2020
+        'logical-assignment-operators': 'off'
     }
 };