Skip to content

Commit

Permalink
Make CI use Node version from package.json (#717)
Browse files Browse the repository at this point in the history
* CI use Node version from package.json

Signed-off-by: Ahmad Kadri <[email protected]>

* fix the path

Signed-off-by: Ahmad Kadri <[email protected]>

* fix the path overall

Signed-off-by: Ahmad Kadri <[email protected]>

* add engines to root pacakge.json

Signed-off-by: Ahmad Kadri <[email protected]>

* fix the path

Signed-off-by: Ahmad Kadri <[email protected]>

* fix the path in all places

Signed-off-by: Ahmad Kadri <[email protected]>

* fix the path in all places to the right path

Signed-off-by: Ahmad Kadri <[email protected]>

* fix the path

Signed-off-by: Ahmad Kadri <[email protected]>

---------

Signed-off-by: Ahmad Kadri <[email protected]>
  • Loading branch information
ahmadkadri authored Dec 10, 2024
1 parent 3ca6af5 commit 58258c3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'package.json'
cache: 'yarn'

- name: yarn install
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'matrix-meetings-bot/package.json'
cache: 'yarn'

- name: yarn install
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'package.json'
cache: 'yarn'

- name: yarn install
Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'package.json'
cache: 'yarn'

- name: yarn install
Expand Down
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
"prettier-plugin-organize-imports": "^4.1.0",
"yarn-deduplicate": "^6.0.2"
},
"engines": {
"node": ">=20",
"yarn": ">=1.22.1 <2.0.0"
},
"scripts": {
"start": "yarn workspace @nordeck/matrix-meetings-widget start",
"dev": "yarn workspace @nordeck/matrix-meetings-widget dev",
Expand Down

0 comments on commit 58258c3

Please sign in to comment.