Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI use Node version from package.json #717

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Make CI use Node version from package.json #717

merged 8 commits into from
Dec 10, 2024

Conversation

ahmadkadri
Copy link
Contributor

@ahmadkadri ahmadkadri commented Dec 9, 2024 •
edited
Loading

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@ahmadkadri ahmadkadri requested a review from a team as a code owner December 9, 2024 08:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3880b18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ahmadkadri
fix the path
c2b3d0a 
Signed-off-by: Ahmad Kadri <[email protected]>
@ahmadkadri
fix the path overall
01b292e 
Signed-off-by: Ahmad Kadri <[email protected]>
@ahmadkadri
add engines to root pacakge.json
9f31126 
Signed-off-by: Ahmad Kadri <[email protected]>
@ahmadkadri
fix the path
cdc48d1 
Signed-off-by: Ahmad Kadri <[email protected]>
HarHarLinks
HarHarLinks requested changes Dec 9, 2024
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -104,7 +104,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'e2e/package.json'
Copy link
Contributor

@HarHarLinks HarHarLinks Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot sollte seine eigene oder root nutzen
bot should use its own or root

.github/workflows/ci.yml Outdated
@@ -200,7 +200,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'e2e/package.json'
Copy link
Contributor

@HarHarLinks HarHarLinks Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changesets sollte root nutzen
changesets should use root

.github/workflows/ci.yml Outdated
@@ -237,7 +237,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'e2e/package.json'
Copy link
Contributor

@HarHarLinks HarHarLinks Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e kann e2e nutzen, oder root
e2e can continue using e2e, or use root

@ahmadkadri ahmadkadri merged commit 58258c3 into main Dec 10, 2024
6 checks passed
@ahmadkadri ahmadkadri deleted the nic/feat/NEO-1063-Make-CI-use-the-package.json-node-version branch December 10, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarHarLinks HarHarLinks HarHarLinks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadkadri @HarHarLinks