Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI use Node version from package.json #717

Merged
merged 8 commits into from
Dec 10, 2024
+8 −4
Merged

Make CI use Node version from package.json #717

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d6c1a4c
CI use Node version from package.json
ahmadkadri Dec 9, 2024
c2b3d0a
fix the path
ahmadkadri Dec 9, 2024
01b292e
fix the path overall
ahmadkadri Dec 9, 2024
9f31126
add engines to root pacakge.json
ahmadkadri Dec 9, 2024
cdc48d1
fix the path
ahmadkadri Dec 9, 2024
2ace198
fix the path in all places
ahmadkadri Dec 9, 2024
2621a56
fix the path in all places to the right path
ahmadkadri Dec 9, 2024
3880b18
fix the path
ahmadkadri Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'package.json'
cache: 'yarn'

- name: yarn install
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'e2e/package.json'
Copy link
Contributor

@HarHarLinks HarHarLinks Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot sollte seine eigene oder root nutzen
bot should use its own or root

cache: 'yarn'

- name: yarn install
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'e2e/package.json'
Copy link
Contributor

@HarHarLinks HarHarLinks Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changesets sollte root nutzen
changesets should use root

cache: 'yarn'

- name: yarn install
Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: 'e2e/package.json'
Copy link
Contributor

@HarHarLinks HarHarLinks Dec 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e kann e2e nutzen, oder root
e2e can continue using e2e, or use root

cache: 'yarn'

- name: yarn install
Expand Down
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
"prettier-plugin-organize-imports": "^4.1.0",
"yarn-deduplicate": "^6.0.2"
},
"engines": {
"node": ">=20",
"yarn": ">=1.22.1 <2.0.0"
},
"scripts": {
"start": "yarn workspace @nordeck/matrix-meetings-widget start",
"dev": "yarn workspace @nordeck/matrix-meetings-widget dev",
Expand Down
Loading