-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
could it be zero-dependency? #45
Comments
Hi @thilllon, good idea to look into making this package zero-dependency. Thus dependencies are necessary for the schematics. Should try if the schematics still works when the dependencies move to |
Yes, you are right. "schematics" requires those angular~~ things. But all the "schematics" commands are expected to be executed in development stage, not in runtime. So I expect that "schematics" are going to work well. Thanks for checking it out. |
Tried to move the schematic dependencies to dev, but this is what nest add [email protected]
✔ Package installation in progress... ☕
Starting library setup...
Error: Cannot find module '@schematics/angular/utility/dependencies'
Require stack:
- /Users//nest-test/node_modules/nestjs-prisma/schematics/nestjs-prisma/index.js
- /Users/nest-test/node_modules/@angular-devkit/schematics/tools/export-ref.js
- /Users//nest-test/node_modules/@angular-devkit/schematics/tools/index.js
- /Users//nest-test/node_modules/@angular-devkit/schematics-cli/bin/schematics.js
Failed to execute command: node nestjs-prisma:nest-add --source-root="src" /Users/.fnm/node-versions/v16.16.0/installation/bin/node /Users/Library/Caches/fnm_multishells/20081_1673893049928/bin/nest add [email protected] |
Hi,
I think, there is no problem with the following packages moving into devDependencies. Rather, so it can be made with zero-dependency. What do you think?
nestjs-prisma/package.json
Lines 39 to 43 in 1be6f3b
The text was updated successfully, but these errors were encountered: