Subgraph: which delegates represent which nouns doesn't account for token vote snapshots

[eladmallel]

A concerte example:

1. proposal 250 was created
2. noun 652 was born
3. address 0xbc3ed6b537f2980e66f396fe14210a56ba3f72c4 got delegated noun 652
4. 0xbc3ed6b537f2980e66f396fe14210a56ba3f72c4 voted on prop 250
5. under votes, id "0xbc3ed6b537f2980e66f396fe14210a56ba3f72c4-250" you can see noun 652, when it should not be there

[wilsoncusack]

in handleCastVote, vote.nouns is set to voter.nounsRepresented https://github.com/nounsDAO/nouns-monorepo/blob/master/packages/nouns-subgraph/src/nouns-dao.ts#L168

nounsRepresented is changed at the time of Noun transfer or delegation change https://github.com/nounsDAO/nouns-monorepo/blob/master/packages/nouns-subgraph/src/nouns-erc-721.ts

As voting power is frozen at the block a proposal was put up, but nounsRepresented is not, vote.nouns will be misleading.

[solimander]

For now, please use the following workaround, which requires two queries:

{
  proposal(id: ${proposalId}) {
    createdBlock
    votes {
      voter {
        id
      }
      # whatever else you need...
    }
  }
}

{
  delegates(where: { id_in: ${JSON.stringify(voterIds)} }, block: { number: ${createdBlock} }) {
    id
    nounsRepresented {
      id
    }
  }
}