Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification on etherscan failure when deploying with forge #709

Open
davidbrai opened this issue May 29, 2023 · 5 comments
Open

Verification on etherscan failure when deploying with forge #709

davidbrai opened this issue May 29, 2023 · 5 comments

Comments

@davidbrai
Copy link
Collaborator

When trying to deploy DAO V3 contracts to goerli, the following error happened when trying to verify the contracts using forge:

Submitting verification for [contracts/governance/NounsDAOV3DynamicQuorum.sol:NounsDAOV3DynamicQuorum] "0x266E2735a5190813C745e6B34c2708bF60e33417".
Submitted contract for verification:
    Response: `OK`
    GUID: `yeihhiyrj1ed7ermrjxq4w7t8hk4muda2wjk9jnaqyrhjq5dbh`
    URL:
        https://goerli.etherscan.io/address/0x266e2735a5190813c745e6b34c2708bf60e33417
Contract verification status:
Response: `NOTOK`
Details: `Pending in queue`
Contract verification status:
Response: `NOTOK`
Details: `Fail - Unable to verify. Solidity Compilation Error: Source "../../node_modules/@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol" not found: File not found. Searched the following locations: "".`

Not sure what the root cause is, but a temporary fix was to change the node_modules path in foundry.toml from relative to absolute path.

i.e.:

[profile.default]
 src = 'contracts'
-libs = ['lib', '../../node_modules']
+libs = ['lib', '/full-path-to-project/my-monorepo/node_modules']
@ShubhSensei
Copy link

can i work on this issue?

@davidbrai
Copy link
Collaborator Author

can i work on this issue?

go ahead

@davidbrai
Copy link
Collaborator Author

related: foundry-rs/foundry#4060

@ShubhSensei
Copy link

related: foundry-rs/foundry#4060

Thanx for the reference

@ShubhSensei
Copy link

It seems that the problem is in the Foundry codebase & not in the NounDAO itself. what's say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants