Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Advisory IDs returned by audit have changed #4550

Closed
2 tasks done
naugtur opened this issue Mar 10, 2022 · 3 comments
Closed
2 tasks done

[BUG] Advisory IDs returned by audit have changed #4550

naugtur opened this issue Mar 10, 2022 · 3 comments
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release

Comments

@naugtur
Copy link

naugtur commented Mar 10, 2022

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

There's been multiple reports of advisory ID changes here: naugtur/npm-audit-resolver#56

Advisory ID saved from earlier npm audit --json is not matching the current output.

Expected Behavior

Advisory IDs don't change.

Steps To Reproduce

  1. Take a file where an advisory ID was saved in the past
  2. Run npm audit --json for the same vulnerable package
  3. Observe a different value

Environment

  • npm: 7+
  • Node.js: any
  • OS Name: any
@naugtur naugtur added Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release labels Mar 10, 2022
@naugtur
Copy link
Author

naugtur commented Mar 10, 2022

Some folks were suggesting it may be related to npm advisory page now redirecting to github advisories.

IF that's the case - is there something I could use to exchange the old ID for the new one to make a one-off tool to fix the situation?

@adevine
Copy link

adevine commented Mar 10, 2022

As one point of clarification, we are seeing the advisory IDs change frequently, i.e. I'd save a resolution file with npm-audit-resolver, then the IDs would change the next day, then I'd update the resolution file, only to have it break the next day again.

@wraithgar
Copy link
Member

Those numbers are controlled by the npm registry itself, not the cli. Registry support should go through https://www.npmjs.com/support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs review for next steps Release 8.x work is associated with a specific npm 8 release
Projects
None yet
Development

No branches or pull requests

3 participants