Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for NPR app #4

Open
3 of 5 tasks
alykat opened this issue Jul 2, 2024 · 1 comment
Open
3 of 5 tasks

Updates for NPR app #4

alykat opened this issue Jul 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@alykat
Copy link
Member

alykat commented Jul 2, 2024

Per EA:

  • Embed respects dark mode/light mode of the app
  • Add the option to display a promo image above the embed headline, ideally pulling in the promo image set on the live blog in Grove.
  • Display publish time next to the date line below each headline on the embed
    • Built-in relative timestamps are fine
  • Adjust bottom padding on iOS to leave more space below the last headline on the module view
  • Adjust left side padding on iOS to match up alignment of embed headline with the title of module

Would like to have this sorted in time for the DNC (Aug 19-22)

IMG_7732

@alykat alykat added the enhancement New feature or request label Jul 2, 2024
@alykat
Copy link
Member Author

alykat commented Jul 2, 2024

Add the option to display a promo image above the embed headline, ideally pulling in the promo image set on the live blog in Grove.

We might not be able to do this via the embed, as the embed only knows what's in the RSS feed, and the liveblog RSS feed doesn't include the primary image assigned to the liveblog:
https://www.npr.org/live-updates/student-loan-forgiveness-how-to-apply.rss
https://www.npr.org/live-updates/trump-biden-presidential-debate-2024.rss

Could hardcode it into the snippet we're using to get the embed code to the app tho?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant