Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow #2

Open
nrempel opened this issue Apr 15, 2023 · 2 comments
Open

Fix release workflow #2

nrempel opened this issue Apr 15, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@nrempel
Copy link
Owner

nrempel commented Apr 15, 2023

https://github.com/nrempel/sleek/blob/main/.github/workflows/release.yml

This workflow should build a release binary for every platform and make it available as a Github release when a version tag is pushed. It's not working right now.

@nrempel nrempel added the help wanted Extra attention is needed label Apr 15, 2023
@balling-dev
Copy link

balling-dev commented Jan 17, 2024

Thanks for sleek.

In my fork, I added a working release workflow using cargo dist (see docs).

It creates and uploads binaries for Linux, Mac and Windows to a github release when a commit is tagged with vX.Y.X (note that it does not publish to crates.io).

I will be happy to create a pull request if that is helpful 😃

Br,

./ Kristoffer

PS: Note that since I did not modify the registry entry in Cargo.toml, the top/tabular download links on the release v0.3.1 in my fork do not work, but all the asset downloads do work. If the registry entry points to the correct github repo, the top download links will work as well.

@nrempel
Copy link
Owner Author

nrempel commented Jan 19, 2024

Yes, thank you! Please feel free to up a pull request. That will be very helpful. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants