From 8fab2e7b0427809c6ed72de5ae6d6ad1b8b2c315 Mon Sep 17 00:00:00 2001 From: Nicholas Cunningham Date: Tue, 10 Dec 2024 09:54:50 -0700 Subject: [PATCH] fix(expo): update flaky expo tests --- e2e/expo/src/expo-legacy.test.ts | 9 +++++---- e2e/expo/src/expo.test.ts | 8 ++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/e2e/expo/src/expo-legacy.test.ts b/e2e/expo/src/expo-legacy.test.ts index 39e2b5cea5bcb..6860fb6800233 100644 --- a/e2e/expo/src/expo-legacy.test.ts +++ b/e2e/expo/src/expo-legacy.test.ts @@ -79,7 +79,7 @@ describe('@nx/expo (legacy)', () => { it('should serve with metro', async () => { let process: ChildProcess; - const port = 8081; + const port = 8051; try { process = await runCommandUntil( @@ -168,16 +168,17 @@ describe('@nx/expo (legacy)', () => { }); it('should start', async () => { + const port = 8041; // run start command const startProcess = await runCommandUntil( - `start ${appName} -- --port=8081`, - (output) => output.includes(`http://localhost:8081`) + `start ${appName} -- --port=${port}`, + (output) => output.includes(`http://localhost:${port}`) ); // port and process cleanup try { await promisifiedTreeKill(startProcess.pid, 'SIGKILL'); - await killPorts(8081); + await killPorts(port); } catch (err) { expect(err).toBeFalsy(); } diff --git a/e2e/expo/src/expo.test.ts b/e2e/expo/src/expo.test.ts index c03e1b1fc2a51..3859edc626aa5 100644 --- a/e2e/expo/src/expo.test.ts +++ b/e2e/expo/src/expo.test.ts @@ -55,12 +55,12 @@ describe('@nx/expo', () => { it('should start the app', async () => { let process: ChildProcess; - const port = 8081; + const port = 8088; try { process = await runCommandUntil( `start ${appName} -- --port=${port}`, - (output) => output.includes(`http://localhost:8081`) + (output) => output.includes(`http://localhost:8088`) ); } catch (err) { console.error(err); @@ -74,12 +74,12 @@ describe('@nx/expo', () => { it('should serve the app', async () => { let process: ChildProcess; - const port = 8081; + const port = 8071; try { process = await runCommandUntil( `serve ${appName} -- --port=${port}`, - (output) => output.includes(`http://localhost:8081`) + (output) => output.includes(`http://localhost:8071`) ); } catch (err) { console.error(err);