Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atomized groups have always suffix E2E (CI). This should be toggleable #28066

Open
4 tasks
meeroslav opened this issue Sep 24, 2024 · 1 comment · May be fixed by #29365
Open
4 tasks

Atomized groups have always suffix E2E (CI). This should be toggleable #28066

meeroslav opened this issue Sep 24, 2024 · 1 comment · May be fixed by #29365
Assignees
@meeroslav
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug

Comments

@meeroslav
Copy link
Contributor

Current Behavior

The group name for atomized runs is now hardcoded to E2E (CI) which might be misleading when atomizing unit tests.

Expected Behavior

The group name should be changeable via plugin options.

GitHub Repo

No response

Steps to Reproduce

  1. Atomize tasks via jest plugin and name ciTargetName - test-ci
  2. Run test-ci target
  3. Nx Cloud dashboard shows {project name} - E2E (CI) as a marker of the group

Nx Report

19.8.0

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response
@jaysoo jaysoo added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Sep 25, 2024
tinesoft added a commit to tinesoft/nx that referenced this issue Dec 16, 2024
@tinesoft
feat(core): add option ciGroupName to allow customizing the name of…
ab0b5f3 
… `Jest` atomized taks group on CI

Closes nrwl#28066
@tinesoft tinesoft linked a pull request Dec 16, 2024 that will close this issue
Open
@tinesoft
Copy link
Contributor

tinesoft commented Dec 16, 2024 •
edited
Loading

I was facing that issue (Atomizer enabled on both unit and e2e test for Jest).
I submitted a PR that should fix that issue --> feat(core): add option ciGroupName to allow customizing the name of… #29365

if you don't mind having a look @meeroslav

tinesoft added a commit to tinesoft/nx that referenced this issue Dec 17, 2024
@tinesoft
feat(core): add option ciGroupName to allow customizing the name of…
367b046 
… `Jest` atomized taks group on CI

Closes nrwl#28066
tinesoft added a commit to tinesoft/nx that referenced this issue Dec 17, 2024
@tinesoft
feat(core): add option ciGroupName to allow customizing the name of…
df1d130 
… `Jest` atomized taks group on CI

Closes nrwl#28066
tinesoft added a commit to tinesoft/nx that referenced this issue Dec 18, 2024
@tinesoft
feat(core): add option ciGroupName to allow customizing the name of…
86384d3 
… `Jest` atomized taks group on CI

Closes nrwl#28066
tinesoft added a commit to tinesoft/nx that referenced this issue Dec 19, 2024
@tinesoft
feat(core): add option ciGroupName to allow customizing the name of…
b501652 
… `Jest` atomized taks group on CI

Closes nrwl#28066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meeroslav meeroslav

Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): add option ciGroupName to allow customizing the name of… tinesoft/nx
3 participants
@jaysoo @meeroslav @tinesoft