Add swc as an option to use with node/nestjs builder #8900

tonivj5 · 2022-02-08T10:41:12Z

I'd be willing to implement this feature (contributing guide)

Description

As swc-project/swc#3459 has fixed the use of legacy-decorators, it'd awesome to be able of use swc as compiler/bundler to reduce typescript compilation time 🚀

Motivation

Reduce time of tsc.

Suggested Implementation

swc is used with @nrwl/js and others, use it with @nrwl/node (nestjs) too

Alternate Implementations

esbuild doesn't support ~~legacy decorators~~ emitDecoratorMetadata 😢

The text was updated successfully, but these errors were encountered:

github-actions · 2022-10-23T00:35:08Z

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

tonivj5 · 2022-10-23T07:08:06Z

Up

kdawgwilk · 2023-06-01T19:08:01Z

Looks like its coming to NestCLI so it would be great for Nx to also provide it as an option https://twitter.com/kammysliwiec/status/1664192006019506178?s=20

arivera-xealth · 2023-06-29T14:06:50Z

bump

drackp2m · 2023-06-29T21:55:09Z

I think many of us would love to see this.

AdhamMoussa · 2023-07-03T15:57:24Z

Up

kdawgwilk · 2023-07-03T19:15:29Z

NestJS CLI shipped this in v10 https://trilon.io/blog/nestjs-10-is-now-available#nestjs-%EF%B8%8F-swc

ggagosh · 2023-07-11T10:05:58Z

Given that the latest version of Nx seems to be slowing down the NestJS development process, I was wondering if there are any plans to integrate SWC to potentially improve performance. 🤔

michaeljauk · 2023-07-11T10:10:31Z

Is there anyone willing to work on this?

DavidFencl · 2023-07-18T15:44:43Z

+1 on this. Adding support for SWC would be great for NestJs apps. I've managed to get SWC working with NestJs, but compilation fails on NX library imports.

om-mahato · 2023-07-27T09:13:25Z

+1

thenglong · 2023-07-28T02:43:24Z

+1. This will make development experience so much better.

itspers · 2023-07-29T19:25:12Z

Is it possible to use this nest start -b swc instead of default nx builder?
This nx has interesting curve: first when you start using it - it feels 'right', but then with every update more and more problems occur with angular, react, nest.. to the point where im now sure maintaining just 10 stanalone apps would be much simpler.

mhdismail · 2023-08-06T18:28:13Z

Up.

dragomir-parvanov-riskmethods · 2023-08-10T14:59:47Z

@itspers

I thought I made it working with nest start -b swc, but when I tried to import an nx generated library, the paths were not compiled at all

jacqueslareau · 2023-08-16T13:25:35Z

NestJS so slow in dev since upgrade....

mustafaersoyer · 2023-08-21T06:53:14Z

+1

Jeff909Dev · 2023-08-22T06:45:19Z

Up

DavidFencl · 2023-08-22T06:58:59Z

BTW is there separate issue talking about slow NestJS watch mode? It's seriously annoying. My pretty small app takes 20-30 seconds to recompile every time something changes. It also takes a lot of time for deamon to even notice something changed. It used to be almost instant in previous NX versions. I can provide link to my repo if necessary.

DobroslavR · 2023-09-15T22:14:49Z

Same @DavidFencl

ak2g · 2023-09-20T10:31:12Z

☝️

jurienhamaker · 2023-09-28T19:37:38Z

🆙

DobroslavR · 2023-09-28T23:47:19Z

Can't believe this is not ready yet.

Seeing extremely slow compilation of Nest apps in newest NX versions makes me cry sometimes.

This would solve it pretty easily.

viniciusLouzada · 2023-10-04T04:54:49Z

🆙

c0dewriter · 2023-10-08T14:52:41Z

I got my NestJS working with SWC (p.s. I used npx create-nx-workspace@latest for workspace creation)

1. Install parts of SWC that you needed: `$ npm install @swc/cli @swc/core @swc/jest`

2. Reconfigure your `project.json` file (generated by NX) like this:

  "name": "nx-nest-boilerplate",
  "$schema": "node_modules/nx/schemas/project-schema.json",
  "sourceRoot": "src",
  "projectType": "application",
  "targets": {
    "build": {
      "executor": "@nx/js:swc",   // <---- Important
      "outputs": [
        "{options.outputPath}"
      ],
      "defaultConfiguration": "production",
      "options": {
        "target": "node",
        "compiler": "swc",       // <---- Important
        "swcrc": ".swcrc",       // <---- Important
        "outputPath": "dist/nx-nest-boilerplate",
        "main": "src/main.ts",
        "tsConfig": "tsconfig.app.json",
        "assets": [
          "src/assets"
        ],
        "isolatedConfig": true
      },
      "configurations": {
        "development": {
          "swcrc": ".swcrc"      // <---- Your development swcrc file
        },
        "production": {
          "swcrc": ".swcrc"      // <---- Your production swcrc file
        }
      }
    },
    "serve": {
     ....

3. Create your `.swcrc` file:

{
  "$schema": "https://json.schemastore.org/swcrc",
  "sourceMaps": true,
  "module": {
    "type": "commonjs",       // <---- Important
    "strict": true,
    "strictMode": true
  },
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "decorators": true,
      "dynamicImport": true
    },
    "transform": {
      "legacyDecorator": true,
      "decoratorMetadata": true
    }
  },
  "minify": true
}

Here's my `tsconfig.app.json`:

{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "strictNullChecks": true,
    "strict": true,
    "outDir": "./dist/out-tsc",
    "module": "CommonJS",       // <---- Important
    "declaration": true,
    "removeComments": true,
    "emitDecoratorMetadata": true,   // <---- Important (I think)
    "experimentalDecorators": true,
    "allowSyntheticDefaultImports": true,
    "incremental": true,
    "types": ["node"],
    "target": "ES2021"
  },
  "exclude": ["jest.config.ts", "src/**/*.spec.ts", "src/**/*.test.ts"],
  "include": ["src/**/*.ts"]
}

And here's my environment:

"dependencies": {
    "@nestjs/common": "^10.0.2",
    "@nestjs/core": "^10.0.2",
    "@nestjs/platform-express": "^10.0.2",
    "@swc/cli": "^0.1.62",
    "@swc/core": "^1.3.92",
    "@swc/jest": "^0.2.29",
    "axios": "^1.0.0",
    "reflect-metadata": "^0.1.13",
    "rxjs": "^7.8.0",
    "tslib": "^2.3.0"
},

"devDependencies": {
    "@nestjs/schematics": "^10.0.1",
    "@nestjs/testing": "^10.0.2",
    "@nx/eslint-plugin": "16.10.0",
    "@nx/jest": "16.10.0",
    "@nx/js": "16.10.0",
    "@nx/linter": "16.10.0",
    "@nx/nest": "16.10.0",
    "@nx/node": "16.10.0",
    "@nx/webpack": "16.10.0",
    "@nx/workspace": "16.10.0",
    "@types/jest": "^29.4.0",
    "@types/node": "~18.7.1",
    "@typescript-eslint/eslint-plugin": "^5.60.1",
    "@typescript-eslint/parser": "^5.60.1",
    "eslint": "~8.46.0",
    "eslint-config-prettier": "8.1.0",
    "jest": "^29.4.1",
    "jest-environment-node": "^29.4.1",
    "nx": "16.10.0",
    "nx-cloud": "latest",
    "prettier": "^2.6.2",
    "ts-jest": "^29.1.0",
    "ts-node": "10.9.1",
    "typescript": "~5.1.3"
}

DobroslavR · 2023-10-08T15:57:02Z

@c0dewriter can you make public repo with this?

wilson208 · 2023-10-08T23:36:45Z

{
  "$schema": "https://json.schemastore.org/swcrc",
  "sourceMaps": true,
  "module": {
    "type": "commonjs",       // <---- Important
    "strict": true,
    "strictMode": true
  },
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "decorators": true,
      "dynamicImport": true
    },
    "transform": {
      "legacyDecorator": true,
      "decoratorMetadata": true
    }
  },
  "minify": true
}

@c0dewriter thanks for these snippets. I can compile a new standalone NestJS app in NX, however imports from libs aren't working for me with this error at build time

 File 'libs/nest-stripe/index.ts' is not under 'rootDir' 'apps/api'. 'rootDir' is expected to contain all source files

pf1gura · 2023-10-09T10:34:07Z

This is the main issue here and probably why it takes so long. Executor do more stuff than just wrapping underlying tech (like swc). It also has to rewrite your imports depending on the command you run. serve has to read all your sources directly (most likely TypeScript files) from packages/libs directory. In build mode it uses compiled source code from dist. In order to do that it needs to create dynamic configuration files depending on the command and do few other things to wire everything.

If you want all the nice things that nx gives you for monorepo management you have to accept that you won't always be able to use latest and greatest from the framework that nx wraps.

wilson208 · 2023-10-09T11:54:12Z

@pf1gura thanks for your insight. Given the solution above uses the existing '@nx/js:swc' executor I made an assumption that this executor would already handle imports from libs. @c0dewriter posted a potential solution, I tried it and gave feedback, I'm just keen for a solution because my NestJS build times have been very slow after the release of v10 and the nx monorepo I work with day to day has 6 different NestJS applications and the DX isn't great right now.

pf1gura · 2023-10-09T14:26:34Z

If I recall correctly existing swc executor is for libraries only. You can use it in your shared TypeScript libraries to speed up library build times but final build of your application still has to go through node executor (which does not use swc)

quesurifn · 2023-10-20T01:08:31Z

@wilson208 I'm actually seeing the same rootDir bug. Have you found a fix yet?

mandarini · 2023-10-25T12:04:28Z

@quesurifn @wilson208 and anyone else, is it possible that your build target names (of two interdependent libs) are different? This bug can appear if you are importing one buildable lib into the other, and the build target names are different.

related: #11289

For anyone having that error, solution: #17798 (comment)

ggagosh · 2023-11-18T12:48:27Z

@quesurifn @wilson208 and anyone else, is it possible that your build target names (of two interdependent libs) are different? This bug can appear if you are importing one buildable lib into the other, and the build target names are different.

related: #11289

For anyone having that error, solution: #17798 (comment)

I'm currently working on integrating SWC into my NestJS application using NX. In my setup, I have shared libraries that are non-buildable, so the solution you mentioned doesn't seem applicable in my case.

Is there an alternative approach or workaround that could make this integration possible?

leosvelperez · 2023-11-23T11:31:54Z

There are many things being discussed in this thread. Let's try to keep it focused on the original request (supporting swc).

Anyone with the 'rootDir' is expected to contain all source files error, please see #11289 (comment). You can follow the conversation over there.

quesurifn · 2023-11-29T23:50:37Z

@mandarini Indeed that was the issue. I encountered this with TS now. For some reason TS didn't trigger the same error until I did a complete refactor but I indeed did have circular dependencies that were two buildable libs referencing each other. The fix was to put them into one lib and then break them up with ts paths so semantically, at least, there is some differentiation.

quesurifn · 2023-11-29T23:51:23Z

@ggagosh I would try looking even if they are not buildable. Also if you're using TS they are indeed buildable. I fixed mine from putting libs that imported each other into the same lib.

kdawgwilk · 2023-11-30T08:39:20Z

I also used the https://github.com/pahen/madge tool to help find some circular deps issues that was blocking swc from being able to compile my projects

SahilMahadwar · 2023-12-31T17:03:56Z

+1

sasha-flow · 2024-03-12T10:02:59Z

SWC support for NestJS apps is still required

tonivj5 added the type: feature label Feb 8, 2022

FrozenPandaz added the scope: node Issues related to Node, Express, NestJS support for Nx label Feb 14, 2022

jase88 mentioned this issue May 18, 2022

Being able to configure to use swc compiler for Cypress tests within @nrwl/cypress #10363

Closed

1 task

github-actions bot added the stale label Oct 23, 2022

github-actions bot removed the stale label Oct 24, 2022

Bielik20 mentioned this issue Oct 27, 2022

@nrwl/webpack with swc doesn't work with reflect-metadata/emitDecoratorMetadata #12845

Closed

jacqueslareau mentioned this issue Aug 16, 2023

Support running nest with swc #17791

Closed

nrwl locked and limited conversation to collaborators Apr 2, 2024

FrozenPandaz converted this issue into discussion #22632 Apr 2, 2024

This issue was moved to a discussion.

Add swc as an option to use with node/nestjs builder #8900

Add swc as an option to use with node/nestjs builder #8900

Comments

tonivj5 commented Feb 8, 2022 • edited Loading

Description

Motivation

Suggested Implementation

Alternate Implementations

github-actions bot commented Oct 23, 2022

tonivj5 commented Oct 23, 2022

kdawgwilk commented Jun 1, 2023

arivera-xealth commented Jun 29, 2023

drackp2m commented Jun 29, 2023

AdhamMoussa commented Jul 3, 2023

kdawgwilk commented Jul 3, 2023

ggagosh commented Jul 11, 2023

michaeljauk commented Jul 11, 2023

DavidFencl commented Jul 18, 2023

om-mahato commented Jul 27, 2023

thenglong commented Jul 28, 2023

itspers commented Jul 29, 2023

mhdismail commented Aug 6, 2023

dragomir-parvanov-riskmethods commented Aug 10, 2023 • edited Loading

jacqueslareau commented Aug 16, 2023

mustafaersoyer commented Aug 21, 2023

Jeff909Dev commented Aug 22, 2023

DavidFencl commented Aug 22, 2023

DobroslavR commented Sep 15, 2023

ak2g commented Sep 20, 2023

jurienhamaker commented Sep 28, 2023

DobroslavR commented Sep 28, 2023 • edited Loading

viniciusLouzada commented Oct 4, 2023

c0dewriter commented Oct 8, 2023

1. Install parts of SWC that you needed: $ npm install @swc/cli @swc/core @swc/jest

2. Reconfigure your project.json file (generated by NX) like this:

3. Create your .swcrc file:

Here's my tsconfig.app.json:

And here's my environment:

DobroslavR commented Oct 8, 2023

wilson208 commented Oct 8, 2023

pf1gura commented Oct 9, 2023

wilson208 commented Oct 9, 2023 • edited Loading

pf1gura commented Oct 9, 2023

quesurifn commented Oct 20, 2023

mandarini commented Oct 25, 2023 • edited Loading

ggagosh commented Nov 18, 2023

leosvelperez commented Nov 23, 2023

quesurifn commented Nov 29, 2023

quesurifn commented Nov 29, 2023 • edited Loading

kdawgwilk commented Nov 30, 2023

SahilMahadwar commented Dec 31, 2023

sasha-flow commented Mar 12, 2024

This issue was moved to a discussion.

tonivj5 commented Feb 8, 2022 •

edited

Loading

dragomir-parvanov-riskmethods commented Aug 10, 2023 •

edited

Loading

DobroslavR commented Sep 28, 2023 •

edited

Loading

1. Install parts of SWC that you needed: `$ npm install @swc/cli @swc/core @swc/jest`

2. Reconfigure your `project.json` file (generated by NX) like this:

3. Create your `.swcrc` file:

Here's my `tsconfig.app.json`:

wilson208 commented Oct 9, 2023 •

edited

Loading

mandarini commented Oct 25, 2023 •

edited

Loading

quesurifn commented Nov 29, 2023 •

edited

Loading