Revert "fix: vite root directory not taken into account when set" #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this PR was merged in error. The
outDir
androot
options are 2 separate things in vite, one should not be used to compute the other.This caused a bug in our build pipeline
/Users/yannick/project/src
/Users/yannick/project/dist
With this change, the cesium files are now generated in
/Users/yannick/project/src/Users/yannick/project/dist/cesium
. But both root and outDir options are correctly configured.@jfayot it doesn't look like this plugin was using the root folder of the project at all before, so I don't understand how using a different
root
than the default would break this plugin. But if you can provide more details I'd be happy to look into it!