Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for "unrated lines" #319

Closed
hazelshapiro opened this issue Sep 10, 2024 · 5 comments · Fixed by #332
Closed

Allow for "unrated lines" #319

hazelshapiro opened this issue Sep 10, 2024 · 5 comments · Fixed by #332
Labels
enhancement New feature or request impact/datamodel Impacts structure of data in the database impact/ui Impacts the the user interface

Comments

@hazelshapiro
Copy link
Collaborator

hazelshapiro commented Sep 10, 2024

Connections between objects without associated performance & criticality ratings (analyst left it blank) would be gray and medium thickness (render as if the value is 5).

This would let us help analysts enter information without immediately doing the rating, and allow for a "prefer not to rate" for sensitive or unknown information.

@mfisher87 mfisher87 added impact/datamodel Impacts structure of data in the database enhancement New feature or request labels Sep 10, 2024
@mfisher87 mfisher87 added the impact/ui Impacts the the user interface label Oct 1, 2024
@rmarow
Copy link
Contributor

rmarow commented Oct 2, 2024

  • 1. allow null in DB (criticality and performance)
  • 2. DB migration (must follow above step)
  • 3. change code to set null as grey for performance
  • 4. code to set null as thinner than thinnest thickness for criticality (0.1)
  • 5. add a note about this in the User Guide

@mfisher87
Copy link
Contributor

code to set null as thinner than thinnest thickness for criticality (0.1)

@hazelshapiro We felt that this is a better option than rendering a medium-thickness line for null criticality. There would be no way to differentiate between someone entering 5 and entering null~

@hazelshapiro
Copy link
Collaborator Author

hazelshapiro commented Oct 2, 2024 via email

@mfisher87
Copy link
Contributor

Sounds good. We could also do something like a dashed line but I think that
might be more confusing than helpful.

Interesting idea! 🤔

@rmarow
Copy link
Contributor

rmarow commented Oct 2, 2024

resolved by #332 image of changes @hazelshapiro :
Screen Shot 2024-10-02 at 4 02 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request impact/datamodel Impacts structure of data in the database impact/ui Impacts the the user interface
Projects
Archived in project
3 participants