Skip to content

Commit

Permalink
Merge pull request #3192 from nspcc-dev/rpc-err
Browse files Browse the repository at this point in the history
neorpc: ensure errors.Is and errors.As work properly with neorpc.Error
  • Loading branch information
roman-khimov authored Nov 8, 2023
2 parents f8d8b03 + fca7eb3 commit 7045d3b
Showing 1 changed file with 35 additions and 0 deletions.
35 changes: 35 additions & 0 deletions pkg/neorpc/errors_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package neorpc

import (
"errors"
"fmt"
"io/fs"
"testing"

"github.com/stretchr/testify/require"
)

func TestError_ErrorsAs(t *testing.T) {
err := NewInternalServerError("some error")
wrapped := fmt.Errorf("some meaningful error: %w", err)

// Check that Error can be used as a target for errors.As:
var actual *Error
require.True(t, errors.As(wrapped, &actual))
require.Equal(t, "Internal error (-32603) - some error", actual.Error())

var bad *fs.PathError
require.False(t, errors.As(wrapped, &bad))
}

func TestError_ErrorsIs(t *testing.T) {
err := NewInternalServerError("some error")
wrapped := fmt.Errorf("some meaningful error: %w", err)

// Check that Error can be recognized via errors.Is:
ref := NewInternalServerError("another server error")
require.True(t, errors.Is(wrapped, ref))

// Invalid target type:
require.False(t, errors.Is(wrapped, NewInvalidParamsError("invalid params")))
}

0 comments on commit 7045d3b

Please sign in to comment.