Native contract manifest build fixes #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These conditions are about filtering methods out. A method is excluded if its ActiveFrom is strictly higher than the current HF, since if it's the same then it should be present. Otherwise contract is broken at the height of this particular HF. Signed-off-by: Roman Khimov <[email protected]>
Technically, we can always buildHFSpecificMD() if contract is active, but we just optimize the build out in some cases. switch slightly obfuscates this and requires having the call in two branches. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3704 +/- ##
==========================================
- Coverage 83.04% 83.04% -0.01%
==========================================
Files 335 335
Lines 46719 46729 +10
==========================================
+ Hits 38800 38806 +6
- Misses 6327 6332 +5
+ Partials 1592 1591 -1 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Nov 25, 2024
|
Tests suggest that it works fine, we do invoke some C-methods at the C height in tests. |
|
I'm more worried about proper native call scripts. Anyway, the check won't take long, my testnet node is already at 3M+ height. |
|
Both testnet and mainnet are OK up to Domovoi+ height: |
AnnaShaleva
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic fixes from #3700.