go.mod: Upgrade to latest github.com/nspcc-dev/neofs-sdk-go #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2489 +/- ##
==========================================
- Coverage 29.91% 29.84% -0.07%
==========================================
Files 405 405
Lines 30880 30879 -1
==========================================
- Hits 9237 9217 -20
- Misses 20856 20869 +13
- Partials 787 793 +6
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
cthulhu-rider
force-pushed
the
upgrade/sdk-latest
branch
6 times, most recently
from
c936623
to
30d7436
Compare
|
Please upgrade to RC11. |
cthulhu-rider
force-pushed
the
upgrade/sdk-latest
branch
3 times, most recently
from
e4a42f6
to
c1d3b03
Compare
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
|
Lets keep it in sync with #2547. If it is merged first, then #2547 should |
roman-khimov
reviewed
Sep 7, 2023
* `Client` methods' signature were slightly changed * object search `Read` method returns error instead of bool now, but `Iterate` is almost the same and, at the same time, much easier * test randomizers do not return pointers now Signed-off-by: Leonard Lyubich <[email protected]>
The constant is now declared in the NeoFS SDK and has same value, so NeoFS API Go usage is not needed anymore for this. Refs #1147. Signed-off-by: Leonard Lyubich <[email protected]>
After recent changes, NeoFS SDK provides methods to access user container/object attributes only, so there is no more need to filter them manually. Refs #1147. Signed-off-by: Leonard Lyubich <[email protected]>
SDK recently provided full functionality related to object filters, so there is no more need to import API Go lib. Refs #1147. Signed-off-by: Leonard Lyubich <[email protected]>
SDK recently provided constructor of signature instances that can be used when the signature is transmitted differently from the NeoFS API protocol (e.g. in smart contracts or in Control service). Refs #1147. Signed-off-by: Leonard Lyubich <[email protected]>
They have already been resolved earlier. Closes #1147. Signed-off-by: Leonard Lyubich <[email protected]>
|
Conflicts |
cthulhu-rider
force-pushed
the
upgrade/sdk-latest
branch
from
c1d3b03
to
61df6c8
Compare
… only Previously, storage node selected objects with split ID similar to the one in the removed object and marked relatives as garbage. This didn't make any sense when split info was without split ID inside. From now `deleteChildren` accepts `object.SplitID` by value making it impossible to be called without split ID. As a consequence, this method is called from the `delete` one only if node contains split ID of the parent object. Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov
approved these changes
Sep 8, 2023
As you wish. Since that PR it going first, nothing may be done here. |
carpawell
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untagged, but still
i'm in progress with #2488, maybe addtional SDK fixes will be needed