morph: support reloading morph endpoints with sighup #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 23.07% 23.06% -0.01%
==========================================
Files 789 790 +1
Lines 58687 58710 +23
==========================================
Hits 13542 13542
- Misses 44263 44286 +23
Partials 882 882 ☔ View full report in Codecov by Sentry. |
roman-khimov
reviewed
Nov 5, 2024
End-rey
force-pushed
the
1871-support-reloading-morph-endpoints-with-sighup
branch
from
9f93904
to
85609dc
Compare
roman-khimov
reviewed
Nov 5, 2024
End-rey
force-pushed
the
1871-support-reloading-morph-endpoints-with-sighup
branch
2 times, most recently
from
d205b84
to
f92c1b7
Compare
carpawell
reviewed
Nov 5, 2024
End-rey
force-pushed
the
1871-support-reloading-morph-endpoints-with-sighup
branch
3 times, most recently
from
19aff22
to
ac18957
Compare
End-rey
force-pushed
the
1871-support-reloading-morph-endpoints-with-sighup
branch
from
ac18957
to
5c933da
Compare
Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
1871-support-reloading-morph-endpoints-with-sighup
branch
from
5c933da
to
34b581d
Compare
roman-khimov
reviewed
Nov 7, 2024
Add a new function `Client.Reload` that passes the `WithEndpoints` option and updates the `Client` endpoints. Closes the current connection and attempts to reconnect if there is no endpoint in the config to which the client is connected. Node service can be interrupted in this case. Add docs. Closes #1871. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
1871-support-reloading-morph-endpoints-with-sighup
branch
from
34b581d
to
51dacc9
Compare
roman-khimov
approved these changes
Nov 7, 2024
carpawell
approved these changes
Nov 7, 2024
carpawell
deleted the
1871-support-reloading-morph-endpoints-with-sighup
branch
roman-khimov
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1871.