Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reader conditional when reading/merging data_readers #31

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

alan-ghelardi
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • There is an open issue describing the problem that this pr intents to solve.
    • You have a descriptive commit message with a short title (first line).
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior?

When Vessel encounters a data_reader file containing reader conditionals, a
runtime exception (no dispatch macro for ?) is thrown.

  • What is the new behavior (if this is a feature change)?

As of this pull request Vessel reads data_readers files containing reader
conditionals properly.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

@alan-ghelardi
Copy link
Collaborator Author

@hlship do you mind to take a look at this pull request? People reported this issue during the build of their services. In fact, I believe that there is no impact on the feature you implemented recently, but I'd appreciate your comments if I am not paying attention to something.

@alan-ghelardi alan-ghelardi merged commit da2ef26 into master Sep 4, 2023
2 checks passed
@alan-ghelardi alan-ghelardi deleted the reader-conditionals branch September 4, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants