Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light_curve_analysis for multiple models #214

Closed
tylerbarna opened this issue Aug 31, 2023 · 4 comments · May be fixed by #215
Closed

light_curve_analysis for multiple models #214

tylerbarna opened this issue Aug 31, 2023 · 4 comments · May be fixed by #215
Labels
enhancement New feature or request

Comments

@tylerbarna
Copy link
Collaborator

Please fill out relevant sections below; remove those that are unused.

Feature Summary
A function on top of the existing light_curve_analysis that allows for multiple models to be analyzed at once

Usage / behavior
Call multi_model_analysis with the same arguments as light_curve_analysis, but including multiple models and priors in the arguments will result in analyses being executed for each model. Once all analyses are concluded, an optional plot flag will plot all of the model best fits together with the data.

Alternative Solutions
Could alter the behaviour of light_curve_analysis to have adding multiple models and priors to do what I described rather than doing a mix of the models, but I think the suggestion of another function would be better for compatibility

Implementation details
Additional command line function that just calls light_curve_analysis for each associated model and prior before a unique plotting feature to plot them all together onto one plot (with corner plots remaining separate)

Additional context
Would need to account for models taking different amounts of time to fit and also implement some type of cutoff to account for models that stall. Will also need to account for the potential of failed fits.

@tylerbarna tylerbarna added the enhancement New feature or request label Aug 31, 2023
@tylerbarna tylerbarna added this to the Analysis Tools milestone Aug 31, 2023
@sahiljhawar
Copy link
Member

I think multi-model analysis already exists. I don’t exactly remember but somewhere @tsunhopang mentioned that the fluxes/luminosities add up if multiple models are being used at once.

@mcoughlin
Copy link
Member

@sahiljhawar I think what @tylerbarna wants is a function that will loop over model configurations, and presumably compute odds ratios for you.

@sahiljhawar
Copy link
Member

Hmm okay, maybe I understood it wrong.

@tylerbarna
Copy link
Collaborator Author

@sahiljhawar I think what @tylerbarna wants is a function that will loop over model configurations, and presumably compute odds ratios for you.

yeah, this is more along the lines of what I was thinking; the existing ability to use multiple models as a combined fit is why I suggested a separate command to avoid confusion/compatibility issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants