Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML config parser for all executable scripts #234

Open
sahiljhawar opened this issue Sep 13, 2023 · 0 comments
Open

YAML config parser for all executable scripts #234

sahiljhawar opened this issue Sep 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sahiljhawar
Copy link
Member

sahiljhawar commented Sep 13, 2023

In order to have flexbility to run injection creator, SVD creator etc with YAML configs, rename all the main methods in all the executable scripts to something more informative. Create a new main function and call the YAML parser from there. To achieve this, create the YAML parser (#223) script. Parser should be separated from the core logic of each script.

Then for example: analysis.py will look like

from my_module import yaml_parser

def get_parser(...):
  ...

def analysis(...):
  ...

def main(...):
  yaml_parser(analysis, args)

Also, it must be kept in mind that CLI commands should still work; as what we have been doing until now.

This would require the code refactoring on a substantially large scale.

@sahiljhawar sahiljhawar added the enhancement New feature or request label Sep 13, 2023
@sahiljhawar sahiljhawar self-assigned this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant