Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting seems ineffective #31

Open
espinielli opened this issue Nov 4, 2015 · 3 comments
Open

sorting seems ineffective #31

espinielli opened this issue Nov 4, 2015 · 3 comments

Comments

@espinielli
Copy link
Contributor

I tried to see how config.layout.sortChords and config.layout.sortSubgroups work.
A simple test I performed was to set the value to d3.ascending instead of the default d3.descending.

To my surprise I didn't see any visual change.
Did I miss the point or made some mistake?
Could you please elaborate on the rationale for those configuration parameters?

Thanks in advance

@argl
Copy link
Member

argl commented Nov 5, 2015

I found a typo in the charts sources around sortChords, but its still not working for me. Unfortunately I dont have time to dig deeper into this at the moment. See commit 919f6a1

@espinielli
Copy link
Contributor Author

Well spotted!
I will have a look and try to understand the sorting code in layout.js (L81-L86 for groups, L88-L98 for subgroups).

Looking at the code and without trying to understand it, I have a doubt for line 313 in layout.js which maybe should use negation on chords:

if (!chords) resort();

I'll let you know of any discovery...

@espinielli
Copy link
Contributor Author

My observation about line 313 in layout.js doesn't hold...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants