Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test for Progressive #393

Open
juliev0 opened this issue Nov 5, 2024 · 0 comments
Open

e2e test for Progressive #393

juliev0 opened this issue Nov 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Nov 5, 2024

Summary

We will need to start to test the Progressive logic.

I have these 2 options in mind:

  • Add "Progressive" as one variety of the current functional_test.go. Just like ppnd, we'd have some logic in there that's conditionally performed only in the case of progressive
  • Have a separate file altogether, and rename functional_test.go to in_place_update_test.go or something (both "ppnd" and "no strategy" both test updates that are in place, unlike progressive). In this case, we want to avoid a bunch of copy/pasting, and instead create more reusable functions that are shared between this and the progressive test. Note I've been thinking that once we have multiple test files, we may want to incorporate the suite_test.go code directly in the test code file.

Option 2

Update: I think we probably should go with Option 2 after all. This is because Progressive is going to use 2 NumaflowControllerRollouts, so it's different.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the enhancement New feature or request label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant