Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDE for Progressive #402

Open
Tracked by #348
juliev0 opened this issue Nov 12, 2024 · 0 comments
Open
Tracked by #348

USDE for Progressive #402

juliev0 opened this issue Nov 12, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Nov 12, 2024

Summary

For Progressive, there are 3 things to consider:

  1. : Some fields are only safe to change with Progressive and not PPND - this means that even if the user prefers PPND, it should be done with Progressive (or there will be completely breakage otherwise) - the alternative is to delete and re-create.
  2. We still care about all of the data loss fields, which would indicate that we should do "Progressive" rather than "Direct Apply".
  3. if the Image changes, that's a good time to do Progressive, since this is when we can most benefit from the Blue/Green aspect of Progressive.

Examples of Case 1:
Apparently, some changes to e.g. a Pipeline's Reduce Vertex through use of spec.vertices.udf.groupBy, or changing isbsvc from one provider to another, could result in broken Pipeline(s) unless:

  1. the resource(s) are deleted and then recreated, or
  2. Progressive delivery is done

Restructuring of the USDE:

I'm thinking something like this...

dataLoss:                      # case 2: these are the fields we have now
   pipeline:
   interstepbufferservice:
progressiveRequired:  # case 1
   pipeline:
   interstepbufferservice:
progressiveDesired:    # case 3
   pipeline:
   monovertex:

Configurability in numaplane-controller-config.yaml:
If user has selected PPND as their preferred strategy, perhaps they need to indicate if progressive should be used as a backup strategy? (If so, they would use the fields from Case 1 to determine if they needed to do progressive)


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the enhancement New feature or request label Nov 12, 2024
@juliev0 juliev0 mentioned this issue Nov 13, 2024
3 tasks
@juliev0 juliev0 changed the title USDE: Consider that some fields are only safe to change with Progressive and not PPND USDE for Progressive Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants