Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/Edit the data loss fields #414

Closed
juliev0 opened this issue Nov 15, 2024 · 3 comments
Closed

Review/Edit the data loss fields #414

juliev0 opened this issue Nov 15, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Nov 15, 2024

Summary

For Pipeline and InterstepBufferService, we have tried to configure the list of fields that are at risk for data loss (in usde_config.yaml).

For some fields, we concern ourselves with just the field itself changing: example spec.vertices.source.generator gets set when it was previously unset. We care about that, but we don't care if some subfield of it gets modified. For these fields, we set includeSubFields=false.

For other fields, we concern ourselves if either the field changed or if any of its subfields changed: example spec.vertices.source.transformer.container.env. For these fields, wet set includeSubFields=true.

We need a review of these fields .

Note that in the future, we will have a second list of fields which distinguishes the fields which require "Progressive" and not "PPND".


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the enhancement New feature or request label Nov 15, 2024
@juliev0
Copy link
Collaborator Author

juliev0 commented Nov 15, 2024

cc @vigith @afugazzotto

@whynowy
Copy link
Member

whynowy commented Nov 22, 2024

All the fields look good to me. Just some thoughts - most of the time, users might only update the image tag, and I assume it is mostly not breaking, is there a way to simplify the process to only do in-place update in that case?

@juliev0
Copy link
Collaborator Author

juliev0 commented Nov 22, 2024

All the fields look good to me. Just some thoughts - most of the time, users might only update the image tag, and I assume it is mostly not breaking, is there a way to simplify the process to only do in-place update in that case?

The thing is that "mostly not breaking" isn't sufficient. We need to act conservatively.

@juliev0 juliev0 closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants