Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_modin method is deprecated #560

Open
tsaoyu opened this issue Jun 27, 2022 · 5 comments
Open

from_modin method is deprecated #560

tsaoyu opened this issue Jun 27, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@tsaoyu
Copy link

tsaoyu commented Jun 27, 2022

Description

I have tried the from_modin API but it seems PandasOnRayFrame is a depreacted API in Modin. What is the plan to support this API? Also, is this a zero-copy method from the Modin dataframe partitions?

Modin version 0.13.1

Use case

nums is useful together with Modin for distributed ML stack that requires numpy-alike format. However, current support on from_modin is broken due to compatability.

@tsaoyu tsaoyu added the enhancement New feature or request label Jun 27, 2022
@briancpark
Copy link
Member

briancpark commented Jun 27, 2022

Thanks for using NumS. Does your use case need a higher version of Modin?

For reference, we've only tested against modin==0.11.3. Downgrading Modin via this command should resolve the from_modin error.

pip3 install modin==0.11.3

Please let us know if you need features from Modin 0.13.1 to continue.

@tsaoyu
Copy link
Author

tsaoyu commented Jun 27, 2022

There were some big changes in documentation and performance on Modin since 0.13.0. https://github.com/modin-project/modin/releases/tag/0.13.0 and the support on Pandas 1.4 is very attractive as well

@elibol
Copy link
Member

elibol commented Jun 27, 2022

@devin-petersohn at one point we discussed adding formal support to Modin for this type of integration. Do you have any recommendations on how we ought to correct this issue for long-term stability?

@devin-petersohn
Copy link

@elibol we have a developer API now that should be useful here:

https://modin.readthedocs.io/en/stable/flow/modin/distributed/dataframe/pandas.html

Would this work? We are testing this API and it is public/stable. Happy to discuss other ways too!

@elibol
Copy link
Member

elibol commented Jul 1, 2022

Thanks @devin-petersohn! This looks like it will work for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants