Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge legacyPackages and packages in perSystem #7

Closed
brianmcgee opened this issue May 31, 2024 · 2 comments
Closed

Merge legacyPackages and packages in perSystem #7

brianmcgee opened this issue May 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@brianmcgee
Copy link
Member

Is your feature request related to a problem? Please describe.

When using https://github.com/numtide/devshell I cannot use perSystem.devshell.mkShell because of the following:

perSystem = lib.mapAttrs (
_: flake: (flake.packages or flake.legacyPackages or { }).${system} or { }
) inputs;

This prefers the packages attribute over legacyPackages, and in the case of devshell it exposes different things between those two attribute sets.

Describe the solution you'd like

I'm not sure what the correct solution looks like. Maybe a recursive merge, giving precedence to packages?

Describe alternatives you've considered

For now I'm using inputs.devshell.legacyPackages.${system}.mkShell.

@brianmcgee brianmcgee added the enhancement New feature or request label May 31, 2024
@zimbatm
Copy link
Member

zimbatm commented May 31, 2024

Same, no immediate good answer comes to mind. One it would be good to move away from legacyPackages, but then we need an answer to per-system lib constructors like devshell.mkShell.

@zimbatm
Copy link
Member

zimbatm commented Jun 26, 2024

fixed in #17

@zimbatm zimbatm closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants