Cleanly stop a service group if a service exits #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small issue with service groups (that I noticed a few months ago and forgot about myself).
If a service in a group encounters an
EXIT
the whole group stops, but the pidfile isn't cleaned up. To start the service again I would then have to callservice:stop
andservice:start
. By trappingEXIT
, we also cleanly stop the group and will clean up the pidfile.I also added a check to see if the process is still running before killing is. Otherwise we'd get a print saying that the process doesn't exist:
A minimal reproduction of this issue can be found here: https://git.robbevp.be/robbevp/devshell-ruby-reproduction
Updating the devshell input to this branch fixes the issue.