Generating report fails on Thinkpad X1 Carbon Gen5

[azmodude]

Describe the bug

When trying to generate a JSON report on a - rather old - Thinkpad Carbon X1 facter dies almost instantly with

2024/12/16 17:30:54 root.go:120: failed to scan: failed to scan hardware: failed to read input devices: failed to annotate with udev data: failed to parse bus: rmi does not belong to Bus values

Passing in something minimal like --hardware cpu does not seem to change behavior.

To Reproduce

sudo nix run --option experimental-features "nix-command flakes" nixpkgs#nixos-facter -- --log-level=debug -o facter.json

Expected behavior

A facter.json report is being generated.

System information

• Thinkpad X1 Carbon Gen5
• NixOS BUILD_ID="25.05.20241213.3566ab7"

Additional context

Running the same command on my Thinkpad P14s Gen2 on the same software stack works just fine and produces a facter.json report.

[brianmcgee]

rmi is not a supported value in this Bus enum:

nixos-facter/pkg/udev/udev.go

Lines 56 to 75 in bf95127

	//go:generate enumer -type=Bus -json -text -transform=snake -trimprefix Bus -output=./udev_bus.go
	type Bus int //nolint:recvcheck
	const (
	BusAta Bus = iota // ATA (IDE) devices
	BusBluetooth
	BusI8042
	BusI2c // Inter-Integrated Circuit
	BusIeee1394 // Firewire
	BusPci
	BusPciExpress
	BusPcmcia // Personal Computer Memory Card International Association
	BusPlatform // Devices on a system's motherboard
	BusScsi
	BusSerial
	BusSerio // Serial interface controller devices
	BusSpi // Serial Peripheral Interface connected devices
	BusUsb
	BusVirtio
	)

I can't remember where I got that list from, I believe it was from udev source. I'll find some time in the next couple days to have a closer look and try to ensure full coverage of that field type.

[azmodude]

@brianmcgee thanks a lot. Nothing pressing on my side, just stumbled upon this issue when resurrecting that old laptop from the shelf. ;)