Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: Document new StageSchema class and compute_schema changes #1252

Closed
2 tasks done
dagardner-nv opened this issue Oct 9, 2023 · 0 comments · Fixed by #1341
Closed
2 tasks done

[DOC]: Document new StageSchema class and compute_schema changes #1252

dagardner-nv opened this issue Oct 9, 2023 · 0 comments · Fixed by #1341
Assignees
Labels
doc Improvements or additions to documentation
Milestone

Comments

@dagardner-nv
Copy link
Contributor

How would you describe the priority of this documentation request

Critical (currently preventing usage)

Describe the future/missing documentation

PR #1233 introduces new breaking API changes. We need to document the new compute_schema functionality, and update existing documentation broken by the change.

Where have you looked?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the doc Improvements or additions to documentation label Oct 9, 2023
@dagardner-nv dagardner-nv self-assigned this Oct 9, 2023
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Nov 3, 2023
@dagardner-nv dagardner-nv added this to the 23.11 - MNMG milestone Nov 6, 2023
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Nov 6, 2023
@jarmak-nv jarmak-nv moved this from Review - Ready for Review to In Progress in Morpheus Boards Nov 6, 2023
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Nov 7, 2023
rapids-bot bot pushed a commit that referenced this issue Nov 22, 2023
…1341)

* Update developer documentation to reflect new `compute_schema` changes.
* Cherry-pick `--run_milvus` flag from `fea-sherlock` (unrelated I just needed to quickly run the rest of the tests)
* Fix long-standing bug in `examples/developer_guide/3_simple_cpp_stage/pass_thru.py`, where the Python impl can support messages of any type, but the C++ impl only supports `MultiMessage`
* Copy code snippets from `docs/source/developer_guide/guides/7_python_modules.md` into `examples/developer_guide/7_python_modules/` allowing them to be tested & validated. Add a simple end-to-end test for the modules & stages (part of #993)
* Update the compound module snippet to operate on `MessageMeta` rather than `int` making it easier to run in a Morpheus pipeline.

Closes #1252 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)

URL: #1341
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant