You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docker release build and smoke test reveals at least one missing import from new Sherlock feature
Minimum reproducible example
./docker/build_container_release.sh
docker run -it --rm nvcr.io/nvidia/morpheus/morpheus:v23.11.00a-runtime bash
morpheus run pipeline-nlp
Relevant log output
Click here to see error details
(morpheus) root@535bddc777ed:/workspace# morpheus run pipeline-nlp
Traceback (most recent call last):
File "/opt/conda/envs/morpheus/bin/morpheus", line 11, in
sys.exit(run_cli())
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/morpheus/cli/run.py", line 20, in run_cli
cli(obj={}, auto_envvar_prefix='MORPHEUS', show_default=True, prog_name="morpheus")
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1686, in invoke
sub_ctx = cmd.make_context(cmd_name, args, parent=ctx)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 943, in make_context
self.parse_args(ctx, args)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1641, in parse_args
echo(ctx.get_help(), color=ctx.color)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 704, in get_help
return self.command.get_help(self)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1325, in get_help
self.format_help(ctx, formatter)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1358, in format_help
self.format_options(ctx, formatter)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1564, in format_options
self.format_commands(ctx, formatter)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/click/core.py", line 1617, in format_commands
cmd = self.get_command(ctx, subcommand)
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/morpheus/cli/commands.py", line 142, in get_command
self.commands[cmd_name] = stage_info.build_command()
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/morpheus/cli/stage_registry.py", line 70, in _lazy_build
mod = importlib.import_module(self.package_name)
File "/opt/conda/envs/morpheus/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1050, in _gcd_import
File "", line 1027, in _find_and_load
File "", line 1006, in _find_and_load_unlocked
File "", line 688, in _load_unlocked
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/morpheus/stages/input/rss_source_stage.py", line 22, in
from morpheus.controllers.rss_controller import RSSController
File "/opt/conda/envs/morpheus/lib/python3.10/site-packages/morpheus/controllers/rss_controller.py", line 22, in
import feedparser
ModuleNotFoundError: No module named 'feedparser'
Full env printout
Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]
* Add missing dependencies for `requests`, `requests-cache` and `websockets` to `meta.yaml`
* Dependencies which are only utilized by a single stage are intentionally omitted from `meta.yaml`, even if they appear in `cuda11.8_dev.yml`
* Current that list is: `bs4`, `elasticsearch`, `feedparser` and `milvus`
* Move `MILVUS_DATA_TYPE_MAP` from `morpheus/service/vdb/milvus_client.py` to `tests/test_milvus_vector_db_service.py` which was the only place it was used.
Note: Since these dependencies all exist in `cuda11.8_dev.yml`, there is no effort made to update the tests to optionally skip their associated tests.
Closes#1380
## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.
Authors:
- David Gardner (https://github.com/dagardner-nv)
Approvers:
- Michael Demoret (https://github.com/mdemoret-nv)
URL: #1382
Version
23.11
Which installation method(s) does this occur on?
Docker
Describe the bug.
docker release build and smoke test reveals at least one missing import from new Sherlock feature
Minimum reproducible example
Relevant log output
Click here to see error details
Full env printout
Click here to see environment details
Other/Misc.
4806119 (HEAD -> branch-23.11, upstream/branch-23.11) Merge pull request #1359 from nv-morpheus/fea-sherlock
Code of Conduct
The text was updated successfully, but these errors were encountered: