Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Release container potentially includes unneeded files #1769

Closed
2 tasks done
dagardner-nv opened this issue Jun 27, 2024 · 0 comments · Fixed by #1807
Closed
2 tasks done

[BUG]: Release container potentially includes unneeded files #1769

dagardner-nv opened this issue Jun 27, 2024 · 0 comments · Fixed by #1807
Assignees
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

dagardner-nv commented Jun 27, 2024

Version

24.06

Which installation method(s) does this occur on?

Docker

Describe the bug.

Because we copy files from the host's repo with:

COPY "${MORPHEUS_ROOT_HOST}/docs" "./docs"
COPY "${MORPHEUS_ROOT_HOST}/examples" "./examples"

Which could potentially include intermediate build dirs, *.so files, and intermediate files from the documentation builds

We should probably consider performing a git clone from within the container.

Minimum reproducible example

Build locally in a conda env or in a development container
Build the release container

Relevant log output

Click here to see error details

[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Jun 27, 2024
@dagardner-nv dagardner-nv changed the title [BUG]: Release container includes unneeded build dirs for examples [BUG]: Release container potentially includes unneeded files from examples Jun 28, 2024
@dagardner-nv dagardner-nv changed the title [BUG]: Release container potentially includes unneeded files from examples [BUG]: Release container potentially includes unneeded files Jun 28, 2024
@dagardner-nv dagardner-nv self-assigned this Jul 5, 2024
@morpheus-bot-test morpheus-bot-test bot moved this from Todo to Review - Ready for Review in Morpheus Boards Jul 11, 2024
@rapids-bot rapids-bot bot closed this as completed in 5e0d920 Jul 31, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant