[FEA]: All examples should have a unique output filename #2033
Comments
morpheus-bot-test
bot
moved this from Todo
to Review - Ready for Review
in Morpheus Boards
rapids-bot bot
pushed a commit
that referenced
this issue
Nov 22, 2024
* Ensure each example pipeline produces a unique output file name * Add expected example output filenames to `.gitignore` * Update `ransomware_detection` pipeline to include a unique column * Update `ransomware_detection` adding a `--pipeline_batch_size` flag defaulting to the `model_max_batch_size` avoiding a config warning * Update `Config` to call `_validate_config` from `Config.freeze` instead of the attribute setters, avoids issue where setting attributes becomes order dependent ex: ```python from morpheus.config import Config config = Config() config.model_max_batch_size = 1024 # This line triggers a warning config.pipeline_batch_size = 1024 ``` Includes changes from PR #2040 Closes #2033 Closes #2035 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #2049
github-project-automation
bot
moved this from Review - Ready for Review
to Done
in Morpheus Boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a new feature, an improvement, or a change to existing functionality?
Improvement
How would you describe the priority of this feature request
Low (would be nice)
Please provide a clear description of problem this feature solves
It would be nice when validating workflows if the output of one pipeline didn't overwrite the output of another
Describe your ideal solution
Each output file includes the workflow name ex:
log-parsing-output.jsonlinesrather than
output.jsonlinesAdditional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: