Fix only show add-on incompatibility warning to only show when updati…

…ng to an incompatible API (#17506)

Closes #17490
Fix up of #17370

Summary of the issue:
NVDA still presents the add-on incompatibility message in some situations when updating to a backwards-compatible add-on API with incompatible add-ons installed.

Description of user facing changes
The add-on incompatibility message should no-longer be presented when updating to a backwards-compatible add-on API.

Description of development approach
Updated the logic in `UpdateAskInstallDialog` to match the new logic in `UpdateResultDialog`, so they both only present the warning when updating to a backwards-incompatible API and incompatible add-ons are installed.

Testing strategy:
Tested from source while spoofing to allow update checks, with version (and addon backcompat) set to 2025.1 and 2024.1 (to simulate both situations).

Known issues with pull request:
None.

source/updateCheck.py

@@ -571,7 +571,7 @@ def __init__(self, parent, destPath, version, apiVersion, backCompatTo):
 		# Translators: A message indicating that an update to NVDA is ready to be applied.
 		message = _("Update to NVDA version {version} is ready to be applied.\n").format(version=version)
 
-		showAddonCompat = any(
+		showAddonCompat = (self.backCompatTo[0] > addonAPIVersion.BACK_COMPAT_TO[0]) and any(
 			getIncompatibleAddons(
 				currentAPIVersion=self.apiVersion,
 				backCompatToAPIVersion=self.backCompatTo,

user_docs/en/changes.md

@@ -41,7 +41,7 @@ To use this feature, "allow NVDA to control the volume of other applications" mu
 * In Word and Outlook the result of more font formatting shortcuts is now reported. (#10271, @CyrilleB79)
 * Default input and output braille tables can now be determined based on the NVDA language. (#17306, #16390, #290, @nvdaes)
 * In Microsoft Word, when using the "report focus" command, the document layout will be announced if this information is available and reporting object descriptions is enabled. (#15088, @nvdaes)
-* NVDA will now only warn about add-on incompatibility when updating to a version which has an incompatible add-on API to the currently installed copy. (#17071)
+* NVDA will now only warn about add-on incompatibility when updating to a version which has an incompatible add-on API to the currently installed copy. (#17071, #17506)
 * Added commands to move the review cursor to the first and last character of the selected text, assigned to `NVDA+alt+home` and `NVDA+alt+end`, respectively. (#17299, @nvdaes)
 * Component updates:
   * Updated LibLouis Braille translator to [3.32.0](https://github.com/liblouis/liblouis/releases/tag/v3.32.0). (#17469, @LeonarddeR)