Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shorter startup sound for NVDA launcher #14068

Closed
Qchristensen opened this issue Aug 25, 2022 · 4 comments · Fixed by #17507
Closed

Use shorter startup sound for NVDA launcher #14068

Qchristensen opened this issue Aug 25, 2022 · 4 comments · Fixed by #17507
Labels
component/audio-ux component/installer p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux
Milestone

Comments

@Qchristensen
Copy link
Member

Is your feature request related to a problem? Please describe.

The startup music played by the NVDA launcher (the file you download from https://www.nvaccess.org/download/ ) is relatively long. On fast computers, this may take longer to play than the time taken to load the temporary copy of NVDA.

Describe the solution you'd like

A shorter intro sound, could either play once, or loop for as long as it takes to load NVDA.

Describe alternatives you've considered

We could play the progress bar sound, or a short intro sound followed by the progress bar sound, although this may be confusing for new users, as the same progress bar sound is used later when installing NVDA..

Additional context

@britechguy
Copy link

Question: Is the playing of this sound part of a step-by-step process where nothing else happens until it finishes, or is it asynchronous, that is kicked off to play and then whatever comes afterward goes merrily on its way?

If the issue is that the NVDA temporary copy is taking too long to load because it's waiting for the sound to finish, the playing of that sound could be made asynchronous, as its only real purpose is to alert the user that the NVDA install has begun.

@josephsl
Copy link
Collaborator

Hi,

Async from my tests - I just updated a portable copy of NVDA from 2022.2 to 2022.2.2 and the update commenced before the logo sound finished playing.

Thanks.

@britechguy
Copy link

Thanks for the confirmation. Since it's asynchronous, and given how little processing power is needed to play sounds, you could probably kick off a symphony recording without any significant reduction of speed for the NVDA installer.

Nothing should be waiting if the sound is played asynchronously. So the lag shouldn't be related to this.

@seanbudd seanbudd added triaged Has been triaged, issue is waiting for implementation. component/installer p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority ux component/audio-ux labels Sep 8, 2022
@feerrenrut
Copy link
Contributor

The sound blocks NVDA from being started, if the unpacking stage of the launcher happens faster than the length of the sound then the launcher will be blocked waiting for the sound to complete.

If there is anyone willing to create a replacement sound we'd be happy to work with you.
Please get in touch ([email protected]) and we can discuss the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/audio-ux component/installer p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants