Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the string related to typing command keys #17470

Closed
tarikhadzirovicofficial opened this issue Dec 2, 2024 · 0 comments · Fixed by #17472
Closed

Change the string related to typing command keys #17470

tarikhadzirovicofficial opened this issue Dec 2, 2024 · 0 comments · Fixed by #17472
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2025.1

Comments

@tarikhadzirovicofficial
Copy link

NVDA has the ability to toggle the speaking of keys that are not standard letters or numbers but command keys or shortcuts, such as Tab, Down Arrow, Control+S, and so on.

Steps to reproduce:

  1. Turn on Input Help.
  2. Press NVDA+4.

Explanation

In the NVDA translation file (.po file), there is a string: "Toggles on and off the speaking of typed keys, that are not specifically characters." Meanwhile, the documentation contains a section numbered 12.1.9.10, titled "Speak Command Keys".

I believe it would be beneficial to change the string in the .po file to "Toggles on and off the speaking of command keys."
This may be a small change, but it ensures consistency between NVDA interface messages and the documentation. It could also be a change that better explains this feature to users, especially beginners.
@Adriani90 Adriani90 mentioned this issue Dec 2, 2024
Merged
5 tasks
@seanbudd seanbudd added p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Dec 2, 2024
seanbudd pushed a commit that referenced this issue Dec 2, 2024
@Adriani90
Changed a message in input helm mode for speak command keys command (#…
1fd469a 
…17472)

fixes #17470

Summary of the issue:
Small inconsistency between user guide and input help mode

Description of user facing changes
same message which is spoken when toggling the setting, and can also be found in the user guide.

Description of development approach
Changed the coresponding message in globalCommands.py
@github-actions github-actions bot added this to the 2025.1 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2025.1
Development

Successfully merging a pull request may close this issue.

Changed a message in input help mode for speak command keys command Adriani90/nvda
2 participants
@seanbudd @tarikhadzirovicofficial