Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nuitka to 2.5.4 #17464

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Update nuitka to 2.5.4 #17464

merged 3 commits into from
Dec 1, 2024

Conversation

josephsl
Copy link
Collaborator

@josephsl josephsl commented Dec 1, 2024 •
edited by SaschaCowley
Loading

Link to issue number:

Closes #17458

Summary of the issue:

NVDA is using nuitka 2.4.8 (includes xliff for markdown to HTML generation).

Description of user facing changes

None

Description of development approach

Update nuitka to 2.5.4 and xliff is still working.

Testing strategy:

Manual and documentation generation: make sure nuitka/xliff is working after dependency upgrades.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@josephsl josephsl requested a review from a team as a code owner December 1, 2024 12:55
@josephsl josephsl requested a review from SaschaCowley December 1, 2024 12:55
SaschaCowley
SaschaCowley approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @josephsl

@SaschaCowley
Merge branch 'master' into nuitka-2.5.4
1b7b338 
# Conflicts:
#	user_docs/en/changes.md
@SaschaCowley SaschaCowley merged commit 4a0bf1b into nvaccess:master Dec 1, 2024
4 of 5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Dec 2, 2024
@josephsl josephsl deleted the nuitka-2.5.4 branch December 2, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaCowley SaschaCowley SaschaCowley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.

Update nuitka to 2.5.4
2 participants
@josephsl @SaschaCowley