Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAPI 5 initialisation #17513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SAPI 5 initialisation #17513

wants to merge 1 commit into from

Conversation

SaschaCowley
Copy link
Member

Link to issue number:

Closes #17512
Fix-up of #17496

Summary of the issue:

After the removal of winmm support, SAPI5 synthesisers failed to initialise.
This is because we switched from integer-based IDs as used by winmm, to ID strings as used by Windows Core Audio.

Description of user facing changes

SAPI5 synthesisers now initialise correctly.

Description of development approach

Rather than calling outputDeviceNameToID to index into the audio outputs returned by SAPI, iterate over them and look for one whose Description matches the friendly name of the output device to use as stored in the user's config.

Testing strategy:

Tested loading SAPI5 with a number of output devices selected, and changing output devices with SAPI5 loaded.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley marked this pull request as ready for review December 13, 2024 08:46
@SaschaCowley SaschaCowley requested a review from a team as a code owner December 13, 2024 08:46
@AppVeyorBot
Copy link

See test results for failed build of commit 1c6a4fbd0c

@burmancomp
Copy link
Contributor

Works for me. This should be merged as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load sapi 5 synthesizer
3 participants