Remove waivers #554
Merged
Remove waivers #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 1fb527a): https://nwplus-ubc--pr554-remove-waivers-7geiaxkm.web.app (expires Sun, 14 Jan 2024 00:17:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8c7ea898e009e43455645bc310bcbccfc0f87e48 |
EdwardJXLi
reviewed
Jan 7, 2024
| @@ -21,6 +21,15 @@ export const NOTIFICATION_PERMISSIONS = Object.freeze({ | |||
| DENIED: 'denied', | |||
| }) | |||
|
|
|||
| export const WAIVER_LINKS = Object.freeze({ | |||
| COVID: | |||
| 'https://docs.google.com/document/d/1td2BgcwRT2CTYdUrzHji7onxpoVl8UjMiEuqIIUK7CM/edit?usp=sharing%5C', | |||
There was a problem hiding this comment.
We should remove the trailing space in case that causes issues, but that should be fine
EdwardJXLi
reviewed
Jan 7, 2024
| @@ -27,7 +24,7 @@ const TopDecal = styled.img` | |||
| ` | |||
|
|
|||
| export default withTheme(({ announcements, theme }) => { | |||
| const { user, isAuthed } = useAuth() | |||
| // const { user, isAuthed } = useAuth() | |||
There was a problem hiding this comment.
Okay its for the QR. should be fine for now
added required next to minors text
EdwardJXLi
reviewed
Jan 7, 2024
| This waiver allows nwPlus to use any photos or videos taken during the event for | ||
| promotional purposes. | ||
| </P> | ||
| <A bolded color="primary" width="130px" href={WAIVER_LINKS.RELEASE_LIABILITY}> |
There was a problem hiding this comment.
Very small issue, but we should make the wavers open in the new tab as sometimes the state doesnt get saved when you click directly.
byronwang93
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other considerations